Skip to content

Add admin hoted app local spec#7027

Open
alfonso-noriega wants to merge 2 commits intoadd_manifest_to_include_files_stepfrom
add_admin_config_local_spec
Open

Add admin hoted app local spec#7027
alfonso-noriega wants to merge 2 commits intoadd_manifest_to_include_files_stepfrom
add_admin_config_local_spec

Conversation

@alfonso-noriega
Copy link
Contributor

@alfonso-noriega alfonso-noriega commented Mar 17, 2026 •
edited
Loading

WHY are these changes introduced?

The admin extension type was previously hardcoded as a string literal, which prevented proper specification handling and caused inconsistencies in the extension system.

WHAT is this pull request doing?

  • Creates a new AdminSpecIdentifier constant and corresponding specification file for admin extensions
  • Replaces the hardcoded 'admin' string with the proper AdminSpecIdentifier in the configuration extension IDs array
  • Adds the admin specification to the loaded specifications list
  • Implements admin extension as a contract-based module with single UID strategy and copy files build mode
  • Adds a default case to the extension instance UID generation logic
  • Updates the app configuration schema contribution logic to handle specifications without shape definitions
  • Adds uidStrategy parameter support to contract-based module specifications

How to test your changes?

  1. Create an admin extension in a Shopify app
  2. Verify the extension builds and deploys correctly
  3. Confirm the extension receives a proper UID based on its specification identifier
  4. Test that the hosted app copy files step executes during deployment

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

This was referenced Mar 17, 2026
Open
Closed
@alfonso-noriega Graphite App
Copy link
Contributor Author

alfonso-noriega commented Mar 17, 2026 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from a25fc78 to f1ff200 Compare March 17, 2026 11:02
@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch from 0fd3c26 to 141233b Compare March 17, 2026 11:03
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from f1ff200 to 31060ea Compare March 17, 2026 11:07
@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch from 141233b to 06bccee Compare March 17, 2026 11:07
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from 31060ea to c22afce Compare March 17, 2026 11:19
@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch 2 times, most recently from d13b2b2 to ef2ca4e Compare March 17, 2026 11:20
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from c22afce to 178b934 Compare March 17, 2026 11:20
@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch from ef2ca4e to 9c06d65 Compare March 17, 2026 15:51
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from 178b934 to 010e9ae Compare March 17, 2026 15:51
@alfonso-noriega alfonso-noriega changed the base branch from add_manifest_to_include_files_step to graphite-base/7027 March 18, 2026 10:45
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from 010e9ae to 0de775d Compare March 18, 2026 17:50
@alfonso-noriega alfonso-noriega changed the base branch from graphite-base/7027 to add_manifest_to_include_files_step March 18, 2026 17:50
@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch from 854f0c7 to f4baca8 Compare March 19, 2026 10:38
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from 0de775d to 0420085 Compare March 19, 2026 10:38
@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2026 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 82.37% 15284/18556
🟡 Branches 74.79% 7581/10136
🟢 Functions 81.4% 3824/4698
🟢 Lines 82.79% 14448/17452

Test suite run success

4012 tests passing in 1545 suites.

Report generated by 🧪jest coverage report action from 349975f

@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from 0420085 to 9bb0683 Compare March 19, 2026 12:04
@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch 2 times, most recently from c034d57 to 0c42a4b Compare March 20, 2026 09:34
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch 2 times, most recently from c020200 to 6951bbf Compare March 20, 2026 12:49
@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch 2 times, most recently from 98db2aa to c211225 Compare March 20, 2026 14:38
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from 6951bbf to 206fa23 Compare March 20, 2026 14:38
@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch from c211225 to 94743d0 Compare March 23, 2026 10:14
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from 206fa23 to 4f587b6 Compare March 23, 2026 10:14
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from 4f587b6 to 585b375 Compare March 23, 2026 10:38
@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch from 13626e2 to 84ed2df Compare March 23, 2026 11:16
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch 2 times, most recently from 6ed2061 to cb0fc86 Compare March 23, 2026 12:39
@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch from 84ed2df to 1aa66b4 Compare March 23, 2026 12:39
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from cb0fc86 to 5017c7d Compare March 23, 2026 13:44
@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch from 1aa66b4 to 1f714b0 Compare March 23, 2026 13:44
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from 5017c7d to d497d9b Compare March 23, 2026 13:55
@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch 2 times, most recently from 7f88bb0 to 6682764 Compare March 23, 2026 15:28
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from d497d9b to 280c9ef Compare March 23, 2026 15:28
@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch from 6682764 to ad9db10 Compare March 23, 2026 15:56
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from 280c9ef to 2a51988 Compare March 23, 2026 15:56
@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch from ad9db10 to d49ce18 Compare March 23, 2026 16:15
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch 2 times, most recently from 1e29ddb to a92d832 Compare March 23, 2026 16:42
@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch 2 times, most recently from 64736af to fbb2286 Compare March 23, 2026 17:16
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from a92d832 to 26bcb77 Compare March 23, 2026 17:16
@alfonso-noriega alfonso-noriega marked this pull request as ready for review March 23, 2026 19:07
@alfonso-noriega alfonso-noriega requested a review from a team as a code owner March 23, 2026 19:07
@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2026

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch from fbb2286 to ca967c3 Compare March 23, 2026 19:07
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from 26bcb77 to 341a1da Compare March 23, 2026 19:07
alfonso-noriega and others added 2 commits March 23, 2026 21:47
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from 341a1da to 349975f Compare March 23, 2026 20:49
@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch from ca967c3 to a9f578a Compare March 23, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alfonso-noriega